-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct core-bentley imports (backport #7531) [release/4.11.x] #7645
base: release/4.11.x
Are you sure you want to change the base?
Conversation
Cherry-pick of 3419be8 |
@aruniverse Isn't this a breaking change that goes against our version policy? |
yes while this has breaking changes, we can extract some of the changes (everything but removing the re-exports) and it should be ok |
What's the reason for backporting this? |
If you aren't removing the re-exports, but just updating the other code not to rely on them, the title of the PR should be changed, and it should probably be explained in the description. |
This PR is in draft, and not ready to be reviewed. Agreed, those changes will be done prior to publishing the PR.
Tried updating to a 5.0 pre-release in a test app, and ran into this breaking issue. Trying to understand the blast radius and how many shared pkgs would be impacted while providing an example for other consumers prior to 5.0 |
Co-authored-by: Arun George <[email protected]>
d4fd42f
to
08c5092
Compare
In prep for 5.0, update imports where we were previously re-exporting from core-bentley in core-common (/core/common/src/IModelError.ts)